<html>
<head><meta charset="utf-8"><title>nikos-prs · t-compiler/wg-nll · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/index.html">t-compiler/wg-nll</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/nikos-prs.html">nikos-prs</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="128180757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/nikos-prs/near/128180757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/nikos-prs.html#128180757">(Jun 16 2018 at 21:07)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="116083">@pnkfelix</span>, question for you:</p>
<p>So I have these two PRs:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/pull/51538" target="_blank" title="https://github.com/rust-lang/rust/pull/51538">https://github.com/rust-lang/rust/pull/51538</a></li>
<li><a href="https://github.com/rust-lang/rust/pull/51460" target="_blank" title="https://github.com/rust-lang/rust/pull/51460">https://github.com/rust-lang/rust/pull/51460</a>, which builds on that</li>
</ul>
<p>#51538 has a flaw, but I think I have the fix locally. My question is, would you rather just look at #51460 directly, even though it's long? It also has some "extra commits" that did refactorings I didn't always wind up using later — I could plausibly pull those out, but I'm not sure I want to invest the time (and I do expect to use the refactorings later on)</p>



<a name="128229933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/nikos-prs/near/128229933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/nikos-prs.html#128229933">(Jun 18 2018 at 05:04)</a>:</h4>
<p>I already looked at the prefix (and commented on it)</p>



<a name="128230040"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/nikos-prs/near/128230040" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/nikos-prs.html#128230040">(Jun 18 2018 at 05:08)</a>:</h4>
<p>In general I prefer to attempt to land such factored-out prefixes on their own, in order to aid future bisection attempts. But in this case, I’ll review whichever PR you want; I don’t expect people to be doing much bisection of this portion of NLL’s dev history</p>



<a name="128245509"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/nikos-prs/near/128245509" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/nikos-prs.html#128245509">(Jun 18 2018 at 13:02)</a>:</h4>
<p>one complication is that — in fixing the problems with #51538 — I encountered some further problems that would be hard to fix without some of the refactorings I did later</p>



<a name="128245517"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/nikos-prs/near/128245517" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/nikos-prs.html#128245517">(Jun 18 2018 at 13:03)</a>:</h4>
<p>but I'm leaning now towards "land the immediate fix" and then land the other stuff as a FIXME for later</p>



<a name="128245877"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/nikos-prs/near/128245877" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/nikos-prs.html#128245877">(Jun 18 2018 at 13:12)</a>:</h4>
<p>bah, in writing up my comment, I realize that this change could theoretically affect working code... but you'd have to work pretty hard</p>



<a name="128270564"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/nikos-prs/near/128270564" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/nikos-prs.html#128270564">(Jun 18 2018 at 21:12)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> you still around? I'm still contemplating the best way to fix this</p>



<a name="128270576"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/nikos-prs/near/128270576" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/nikos-prs.html#128270576">(Jun 18 2018 at 21:12)</a>:</h4>
<p>if we do manage to sync tomorrow, it might be helpful for me to try and catch you up on on all the madness i've been doing here</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>